Issue 5232051: code review 5232051: go/scanner: remove AllowIllegalChars mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5232051: code review 5232051: go/scanner: remove AllowIllegalChars mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/scanner: remove AllowIllegalChars mode This mode was needed before for clients of the go/scanner that were parsing non-Go code. All those clients have been moved to scanner or have been deleted from the library.

Patch Set 1 #

Patch Set 2 : diff -r f183ae52d934 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f183ae52d934 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2bfba477d53d https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -31 lines)			Patch
	M	src/pkg/go/scanner/scanner.go	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
	M	src/pkg/go/scanner/scanner_test.go	View	1	2 chunks	+4 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-12 04:42:39 UTC) #1

gri

13 years, 5 months ago (2011-10-12 05:28:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2904af657e75 ***

go/scanner: remove AllowIllegalChars mode

This mode was needed before for clients of
the go/scanner that were parsing non-Go code.
All those clients have been moved to scanner
or have been deleted from the library.

R=r
CC=golang-dev
http://codereview.appspot.com/5232051

Expand All Messages | Collapse All Messages