Issue 5228041: code review 5228041: http: cancel a timer in a test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5228041: code review 5228041: http: cancel a timer in a test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by bradfitz

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: cancel test timers; don't t.Fatalf in other goroutines

Patch Set 1 #

Patch Set 2 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 60279075a700 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -38 lines)			Patch
	M	src/pkg/http/serve_test.go	View	1 2 3	4 chunks	+55 lines, -38 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-06 21:58:52 UTC) #1

bradfitz

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2011-10-06 22:17:51 UTC) #2

bradfitz

13 years, 5 months ago (2011-10-10 00:57:37 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=8dc8fff8b11c ***

http: cancel test timers; don't t.Fatalf in other goroutines

R=rsc
CC=golang-dev
http://codereview.appspot.com/5228041

Expand All Messages | Collapse All Messages