Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 52170043: code review 52170043: cmd/gofmt: remove -tabwidth and -tabs flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by bradfitz
Modified:
10 years, 2 months ago
Reviewers:
minux1, r, gri
CC:
r, gri, golang-codereviews
Visibility:
Public.

Description

cmd/gofmt: remove -tabwidth and -tabs flags Having these flags misleads people into thinking they're acceptable for code that "must be gofmt'd". If an organization wishes to use gofmt internally with different settings, they can fork gofmt trivially. But "gofmt" as used by the community with open source Go code should not support these old knobs. Also removes the -comments flag. Fixes Issue 7101

Patch Set 1 #

Patch Set 2 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 8fb9c633c631 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M src/cmd/gofmt/doc.go View 1 2 3 4 2 chunks +4 lines, -7 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 1 2 3 4 5 6 5 chunks +11 lines, -28 lines 0 comments Download
M src/cmd/gofmt/gofmt_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofmt/long_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
bradfitz
Hello r@golang.org, gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 2 months ago (2014-01-14 18:31:28 UTC) #1
r
LGTM
10 years, 2 months ago (2014-01-14 18:35:27 UTC) #2
gri
doc.go needs to be adjusted as well: Gofmt formats Go programs. It uses tabs (width ...
10 years, 2 months ago (2014-01-14 18:54:21 UTC) #3
bradfitz
Hello r@golang.org, gri@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-14 18:59:37 UTC) #4
bradfitz
https://codereview.appspot.com/52170043/diff/40001/src/cmd/gofmt/gofmt.go File src/cmd/gofmt/gofmt.go (right): https://codereview.appspot.com/52170043/diff/40001/src/cmd/gofmt/gofmt.go#newcode35 src/cmd/gofmt/gofmt.go:35: comments = flag.Bool("comments", true, "print comments") On 2014/01/14 18:54:21, ...
10 years, 2 months ago (2014-01-14 18:59:38 UTC) #5
bradfitz
Hello r@golang.org, gri@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-14 19:06:21 UTC) #6
gri
LGTM Thanks!
10 years, 2 months ago (2014-01-14 19:08:04 UTC) #7
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=34dac78e0550 *** cmd/gofmt: remove -tabwidth and -tabs flags Having these flags misleads ...
10 years, 2 months ago (2014-01-14 19:11:00 UTC) #8
minux1
10 years, 2 months ago (2014-01-14 19:30:00 UTC) #9
we probably need to mention this change in doc/go1.3.txt.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b