Issue 5177049: code review 5177049: runtime: fix Plan 9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5177049: code review 5177049: runtime: fix Plan 9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by ality

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix Plan 9 build This change adds the osyield and usleep functions and code to read the number of processors from /dev/sysstat. I also changed SysAlloc to return nil when brk fails (it was returning -1).

Patch Set 1 #

Patch Set 2 : diff -r 9a4273c962a4 https://code.google.com/p/go/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -11 lines)			Patch
M	src/pkg/runtime/plan9/386/sys.s	View	1	2 chunks	+19 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/plan9/mem.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/plan9/os.h	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/plan9/thread.c	View	1	3 chunks	+43 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2011-10-05 08:16:10 UTC) #1

rsc

13 years, 5 months ago (2011-10-05 16:07:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d3f4c9bb3301 ***

runtime: fix Plan 9 build

This change adds the osyield and usleep
functions and code to read the number of
processors from /dev/sysstat.

I also changed SysAlloc to return nil
when brk fails (it was returning -1).

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5177049

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages