Issue 5164042: code review 5164042: crypto/tls: Add 3DES ciphersuites

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5164042: code review 5164042: crypto/tls: Add 3DES ciphersuites

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by louisk

Modified:
13 years, 5 months ago

Reviewers:
agl1, rsc

CC:
golang-dev, agl1, rsc

Visibility:
Public.

Description

crypto/tls: Add 3DES ciphersuites The following ciphersuites are added: TLS_RSA_WITH_3DES_EDE_CBC_SHA TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA This change helps conform to the TLS1.1 standard because the first ciphersuite is "mandatory" in RFC4346

Patch Set 1 #

Patch Set 2 : diff -r 22fd0c4f58c1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 22fd0c4f58c1 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 22fd0c4f58c1 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -8 lines)			Patch
M	src/pkg/crypto/tls/cipher_suites.go	View	1	4 chunks	+21 lines, -8 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server_test.go	View	1 2 3	4 chunks	+195 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

louisk

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-09-30 16:32:44 UTC) #1

agl1

LGTM although I think the use of fmt is overkill in the test. http://codereview.appspot.com/5164042/diff/3001/src/pkg/crypto/tls/handshake_server_test.go File ...

13 years, 6 months ago (2011-09-30 16:42:09 UTC) #2

louisk

Hello golang-dev@googlegroups.com, agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 6 months ago (2011-09-30 17:50:57 UTC) #4

rsc

13 years, 5 months ago (2011-10-11 17:07:36 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=70c9487632e3 ***

crypto/tls: add 3DES ciphersuites

The following ciphersuites are added:
TLS_RSA_WITH_3DES_EDE_CBC_SHA
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
This change helps conform to the TLS1.1 standard because
the first ciphersuite is "mandatory" in RFC4346

R=golang-dev, agl, rsc
CC=golang-dev
http://codereview.appspot.com/5164042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages