code review 5149045: runtime: append([]byte, string...)

runtime: append([]byte, string...)

Fixes issue 2274

[lvd1, 2011-09-29 17:11:58]

Hello rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-09-29 17:14:26]

This needs a spec change, right?

[dsymonds, 2011-09-29 17:15:22]

On Thu, Sep 29, 2011 at 5:14 PM, David Symonds <dsymonds@golang.org> wrote:

> This needs a spec change, right?

Never mind. I'm blind.

[gri, 2011-09-29 17:22:45]

FYI.

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html#newcode4660
doc/go_spec.html:4660: <a href="#Passing_arguments_to_..._parameters">parameter
passing rules</a> apply.
move the special case description here (in sync w/ the special case for copy)

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html#newcode4676
doc/go_spec.html:4676: to type <code>[]byte</code> with a second argument of a
string type suffixed with <code>...</code>.
"... with a second argument of string type followed by <code>...</code>. This
form appends the string bytes."

[bradfitz, 2011-09-29 17:24:50]

Add to CL description:

Fixes issue 2274

On Thu, Sep 29, 2011 at 10:11 AM, <lvd@golang.org> wrote:

> Reviewers: rsc, gri,
>
> Message:
> Hello rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: append([]byte, string...)
>
> Please review this at
http://codereview.appspot.com/**5149045/<http://codereview.appspot.com/5149045/>
>
> Affected files:
>  M doc/go_spec.html
>  M src/cmd/gc/builtin.c.boot
>  M src/cmd/gc/runtime.go
>  M src/cmd/gc/typecheck.c
>  M src/cmd/gc/walk.c
>  M src/pkg/runtime/slice.c
>  M test/append.go
>
>
>

[lvd, 2011-09-29 19:05:08]

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html#newcode4660
doc/go_spec.html:4660: <a href="#Passing_arguments_to_..._parameters">parameter
passing rules</a> apply.
On 2011/09/29 17:22:50, gri wrote:
> move the special case description here (in sync w/ the special case for copy)

Done.

http://codereview.appspot.com/5149045/diff/9001/doc/go_spec.html#newcode4676
doc/go_spec.html:4676: to type <code>[]byte</code> with a second argument of a
string type suffixed with <code>...</code>.
On 2011/09/29 17:22:50, gri wrote:
> "... with a second argument of string type followed by <code>...</code>. This
> form appends the string bytes."
 done, with s/string bytes/bytes of the string/ (but my intuition of english may
not be better than yours).

[lvd1, 2011-10-12 09:45:47]

Russ, LGTY?

[rsc, 2011-10-12 12:16:45]

LGTM

It would look even better without the spacing changes.

[lvd, 2011-10-12 13:38:27]

On Wed, Oct 12, 2011 at 14:16, <rsc@golang.org> wrote:

> LGTM
>
> It would look even better without the spacing changes.
>

sorry, side effect of whitespace-cleanup and tabify, which i ran b/c hg
upload complained.


>
>
>
http://codereview.appspot.com/**5149045/<http://codereview.appspot.com/5149045/>
>

[lvd, 2011-10-12 13:39:12]

On Wed, Oct 12, 2011 at 15:38, Luuk van Dijk <lvd@google.com> wrote:

>
>
> On Wed, Oct 12, 2011 at 14:16, <rsc@golang.org> wrote:
>
>> LGTM
>>
>> It would look even better without the spacing changes.
>>
>
> sorry, side effect of whitespace-cleanup and tabify, which i ran b/c hg
> upload complained.
>

well, not really _side_ effect, of course.



>
>>
>>
http://codereview.appspot.com/**5149045/<http://codereview.appspot.com/5149045/>
>>
>
>

[lvd1, 2011-10-12 13:59:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=8af9a425d907 ***

runtime: append([]byte, string...)

Fixes issue 2274

R=rsc, gri, dsymonds, bradfitz, lvd
CC=golang-dev
http://codereview.appspot.com/5149045