Issue 51470043: code review 51470043: cmd/link: implement dead code removal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 51470043: code review 51470043: cmd/link: implement dead code removal (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rsc

Modified:
11 years, 2 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/link: implement dead code removal

Patch Set 1 #

Patch Set 2 : diff -r 21fb28e644a1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 21fb28e644a1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 21fb28e644a1 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 21fb28e644a1 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 7276108715ff https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -0 lines)			Patch
M	src/cmd/link/dead.go	View	1 2 3 4 5	1 chunk	+63 lines, -0 lines	0 comments	Download
A	src/cmd/link/dead_test.go	View	1 2 3	1 chunk	+97 lines, -0 lines	0 comments	Download
A	src/cmd/link/testdata/dead.6	View	1 2 3 4	Binary file		0 comments	Download
A	src/cmd/link/testdata/dead.s	View	1 2 3 4	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-01-13 15:03:17 UTC) #1

rsc

11 years, 2 months ago (2014-01-14 04:08:14 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=27eacfd32c7c ***

cmd/link: implement dead code removal

R=iant
CC=golang-codereviews
https://codereview.appspot.com/51470043

Expand All Messages | Collapse All Messages