Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(487)

Issue 51450048: code review 51450048: bench: move unreviewed change from the other repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dvyukov
Modified:
10 years, 2 months ago
Reviewers:
brainman, adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

bench: move unreviewed change from the other repo - sort metrics/files in output - support generating svg profiles (when run manually) - specify explicit output binary name in build benchmark (otherwise it does not work on windows) - make system stats collection work across linux and windows (there is notable hardcore in windows version but that was reviewed by Alex)

Patch Set 1 #

Patch Set 2 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 4 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 5 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 6 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Patch Set 7 : diff -r f2c11d87b6d3 https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -109 lines) Patch
M build/build.go View 1 2 3 4 chunks +8 lines, -25 lines 0 comments Download
M driver/driver.go View 1 2 3 4 8 chunks +30 lines, -10 lines 0 comments Download
M driver/driver_freebsd.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M driver/driver_unix.go View 1 1 chunk +38 lines, -31 lines 0 comments Download
M driver/driver_windows.go View 1 4 chunks +203 lines, -42 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello adg@golang.org (cc: alex.brainman@gmail.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks
10 years, 2 months ago (2014-02-11 13:55:43 UTC) #1
adg
LGTM But as for the windows, I dunno
10 years, 2 months ago (2014-02-12 05:27:58 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=0c40b00e13de&repo=benchmarks *** bench: move unreviewed change from the other repo - sort ...
10 years, 2 months ago (2014-02-12 14:03:47 UTC) #3
brainman
10 years, 2 months ago (2014-02-13 06:31:17 UTC) #4
Message was sent while issue was closed.
On 2014/02/12 05:27:58, adg wrote:
> 
> But as for the windows, I dunno

I checked original windows code. It still looks the same to me ...

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b