Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(842)

Issue 5141051: code review 5141051: go: skeleton implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by rsc
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz, r
Visibility:
Public.

Description

go: skeleton implementation

Patch Set 1 #

Patch Set 2 : diff -r 36826746370e https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r 224c7e1777ed https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 224c7e1777ed https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -0 lines) Patch
A src/cmd/go/Makefile View 1 1 chunk +21 lines, -0 lines 0 comments Download
A src/cmd/go/build.go View 1 1 chunk +57 lines, -0 lines 0 comments Download
A src/cmd/go/clean.go View 1 1 chunk +31 lines, -0 lines 0 comments Download
A src/cmd/go/doc.go View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A src/cmd/go/fix.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
A src/cmd/go/fmt.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
A src/cmd/go/get.go View 1 1 chunk +39 lines, -0 lines 0 comments Download
A src/cmd/go/help.go View 1 1 chunk +178 lines, -0 lines 0 comments Download
A src/cmd/go/list.go View 1 1 chunk +49 lines, -0 lines 0 comments Download
A src/cmd/go/main.go View 1 2 3 1 chunk +174 lines, -0 lines 0 comments Download
A src/cmd/go/script View 1 1 chunk +23 lines, -0 lines 0 comments Download
A src/cmd/go/test.go View 1 1 chunk +32 lines, -0 lines 0 comments Download
A src/cmd/go/version.go View 1 1 chunk +25 lines, -0 lines 0 comments Download
A src/cmd/go/vet.go View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 6 months ago (2011-09-28 23:08:20 UTC) #1
bradfitz
LGTM
12 years, 6 months ago (2011-09-28 23:16:36 UTC) #2
r
LGTM but some comments wouldn't go wrong http://codereview.appspot.com/5141051/diff/2001/src/cmd/go/doc.go File src/cmd/go/doc.go (right): http://codereview.appspot.com/5141051/diff/2001/src/cmd/go/doc.go#newcode14 src/cmd/go/doc.go:14: with a ...
12 years, 6 months ago (2011-09-28 23:32:22 UTC) #3
rsc
On Wed, Sep 28, 2011 at 19:32, <r@golang.org> wrote: > i find these quotes distracting. ...
12 years, 6 months ago (2011-09-28 23:35:30 UTC) #4
rsc
On Wed, Sep 28, 2011 at 19:32, <r@golang.org> wrote: > http://codereview.appspot.com/**5141051/diff/2001/src/cmd/go/** > vet.go#newcode20<http://codereview.appspot.com/5141051/diff/2001/src/cmd/go/vet.go#newcode20> > src/cmd/go/vet.go:20: ...
12 years, 6 months ago (2011-09-29 00:00:45 UTC) #5
rsc
12 years, 6 months ago (2011-09-29 00:07:27 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=7ae32f195afd ***

go: skeleton implementation

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5141051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b