Issue 5136052: code review 5136052: net: add shutdown: TCPConn.CloseWrite and CloseRead

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5136052: code review 5136052: net: add shutdown: TCPConn.CloseWrite and CloseRead (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by bradfitz

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc, iant

Visibility:
Public.

Description

net: add shutdown: TCPConn.CloseWrite and CloseRead

Patch Set 1 #

Patch Set 2 : diff -r 821669218333 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 821669218333 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6c5c19791fae https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -0 lines)			Patch
M	src/pkg/net/fd.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/net/fd_windows.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/net/net_test.go	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download
M	src/pkg/net/tcpsock_posix.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-09-28 14:42:44 UTC) #1

bradfitz

13 years, 5 months ago (2011-09-28 15:12:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f68009c4a907 ***

net: add shutdown: TCPConn.CloseWrite and CloseRead

R=golang-dev, rsc, iant
CC=golang-dev
http://codereview.appspot.com/5136052

Expand All Messages | Collapse All Messages