Issue 5132048: code review 5132048: image: spin off a new color package out of the image pa... (Closed)
Descriptionimage: spin off a new color package out of the image package.
The spin-off renames some types. The new names are simply better:
image.Color -> color.Color
image.ColorModel -> color.Model
image.ColorModelFunc -> color.ModelFunc
image.PalettedColorModel -> color.Palette
image.RGBAColor -> color.RGBA
image.RGBAColorModel -> color.RGBAModel
image.RGBA64Color -> color.RGBA64
image.RGBA64ColorModel -> color.RGBA64Model
(similarly for NRGBAColor, GrayColorModel, etc)
The image.ColorImage type stays in the image package, but is renamed:
image.ColorImage -> image.Uniform
The image.Image implementations (image.RGBA, image.RGBA64, image.NRGBA,
image.Alpha, etc) do not change their name, and gain a nice symmetry:
an image.RGBA is an image of color.RGBA, etc.
The image.Black, image.Opaque uniform images remain unchanged (although
their type is renamed from image.ColorImage to image.Uniform). The
corresponding color types (color.Black, color.Opaque, etc) are new.
Nothing in the image/ycbcr is renamed yet. The ycbcr.YCbCrColor and
ycbcr.YCbCrImage types will eventually migrate to color.YCbCr and
image.YCbCr, but that will be a separate CL.
Patch Set 1 #Patch Set 2 : diff -r 51de42dbe065 https://go.googlecode.com/hg/ #
Total comments: 1
Patch Set 3 : diff -r 087a4bd61f20 https://go.googlecode.com/hg/ #Patch Set 4 : diff -r 087a4bd61f20 https://go.googlecode.com/hg/ #
Total comments: 3
Patch Set 5 : diff -r 087a4bd61f20 https://go.googlecode.com/hg/ #Patch Set 6 : diff -r 087a4bd61f20 https://go.googlecode.com/hg/ #Patch Set 7 : diff -r e144a6dec55e https://go.googlecode.com/hg/ #
MessagesTotal messages: 7
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
