code review 5123047: bytes: add EqualFold

bytes: add EqualFold

[rsc, 2011-09-26 22:42:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-09-26 22:45:57]

LGTM

http://codereview.appspot.com/5123047/diff/5001/src/pkg/bytes/bytes.go
File src/pkg/bytes/bytes.go (right):

http://codereview.appspot.com/5123047/diff/5001/src/pkg/bytes/bytes.go#newcod...
src/pkg/bytes/bytes.go:612: // EqualFold returns true if s and t are equal
UTF-8-encoded strings
strings might not be the word.
// EqualFold returns true if s and t, interpreted as UTF-8, are equal under
Unicode case folding.
(no hyphen)
(perhaps in other pkg too)

http://codereview.appspot.com/5123047/diff/5001/src/pkg/bytes/bytes.go#newcod...
src/pkg/bytes/bytes.go:616: // Extract first rune from each string.
string?

[rsc, 2011-09-26 22:50:03]

I think it's important to say that they are runs of
UTF-8-encoded code points, not just single
code points.
// EqualFold reports whether s and t, interpreted as UTF-8 strings,
// are equal under Unicode case-folding.
?

[r2, 2011-09-26 22:51:04]

On Sep 26, 2011, at 3:49 PM, Russ Cox wrote:

> I think it's important to say that they are runs of
> UTF-8-encoded code points, not just single
> code points.
> // EqualFold reports whether s and t, interpreted as UTF-8 strings,
> // are equal under Unicode case-folding.
> ?

ok

[rsc, 2011-09-26 22:53:38]

Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-09-26 22:55:46]

LGTM

[rsc, 2011-09-26 23:35:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=51de42dbe065 ***

bytes: add EqualFold

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5123047

[cw, 2011-09-27 16:24:11]

(I know this has been submitted already)

Looking over the commits I noticed this.

It occurs to be the name EqualFold isn't very obvious as to what is going on.

Something llike EqualFoldedCase might be clearer?

[rsc, 2011-09-27 16:26:03]

On Tue, Sep 27, 2011 at 12:24,  <cw@f00f.org> wrote:
> It occurs to be the name EqualFold isn't very obvious as to what is
> going on.

if you know the term case-folding, then i think it is obvious.
if you don't, godoc strings EqualFold will make it clear.

what you suggest is very close to what we started with.