code review 51000044: cmd/link: replace golden binary files with hex dumps

cmd/link: replace golden binary files with hex dumps

The hex dumps will diff better, and I hope they will avoid
a repeat of http://bugs.debian.org/716853.

The CL will probably show the testdata diffs as "binary",
but in fact the binary versions are being replaced by
textual hex dumps (output of hexdump -C).

[rsc, 2014-01-13 02:44:41]

Hello iant (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-01-13 18:48:37]

LGTM

What about cmd/link/testdata/hello.6 ?

https://codereview.appspot.com/51000044/diff/40001/src/cmd/link/hex_test.go
File src/cmd/link/hex_test.go (right):

https://codereview.appspot.com/51000044/diff/40001/src/cmd/link/hex_test.go#n...
src/cmd/link/hex_test.go:32: // output of "hexdump" or "hexdump -C" or Plan 9's
"xd -b",
On GNU/Linux this has to be hexdump -C, not hexdump (plain hexdump uses 2-byte
chunks).  I suggest clarifying the comment, either by describing the format or
by saying something like "hexdump" (Darwin) or "hexdump -C" (Linux) or "xd -b"
(Plan 9).

[rsc, 2014-01-14 04:06:21]

On 2014/01/13 18:48:37, iant wrote:
> What about cmd/link/testdata/hello.6 ?

hello.6 is an input, not a golden output. It's generated from hello.s, also
checked in. I suppose I could decode a hex dump into a temporary file and invoke
the linker on that temporary file. I'll do that if I have to but I'd rather not.
I can't run 6a during the test because the file names will be different (and 6a
might not exist, on non-amd64 machines).

>
https://codereview.appspot.com/51000044/diff/40001/src/cmd/link/hex_test.go#n...
> src/cmd/link/hex_test.go:32: // output of "hexdump" or "hexdump -C" or Plan
9's
> "xd -b",
> On GNU/Linux this has to be hexdump -C, not hexdump (plain hexdump uses 2-byte
> chunks).  I suggest clarifying the comment, either by describing the format or
> by saying something like "hexdump" (Darwin) or "hexdump -C" (Linux) or "xd -b"
> (Plan 9).

Done.

[rsc, 2014-01-14 04:07:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=29156b17bdb7 ***

cmd/link: replace golden binary files with hex dumps

The hex dumps will diff better, and I hope they will avoid
a repeat of http://bugs.debian.org/716853.

The CL will probably show the testdata diffs as "binary",
but in fact the binary versions are being replaced by
textual hex dumps (output of hexdump -C).

R=iant
CC=golang-codereviews
https://codereview.appspot.com/51000044