code review 5091044: reflect: add comment about the doubled semantics of Val...

reflect: add comment about the doubled semantics of Value.String.

[r, 2011-09-20 20:11:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-09-20 20:14:53]

I object to 'fetch the string' being called a special case.
The doc comment says:

func (v Value) String() string
String returns the string v's underlying value, as a string.
String is a special case because of Go's String method convention.
Unlike the other getters, it does not panic if v's Kind is not String.
Instead, it returns a string of the form "<T value>" where T is v's type.

(compare with
func (v Value) Float() float64
Float returns v's underlying value, as an float64.
It panics if v's Kind is not Float32 or Float64
)

[r, 2011-09-20 20:22:41]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-09-20 20:25:33]

LGTM

[r, 2011-09-20 20:27:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=f3dd0fa35596 ***

reflect: add comment about the doubled semantics of Value.String.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5091044