Issue 5049043: code review 5049043: [release-branch.r60] json: add struct tag option to wra...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5049043: code review 5049043: [release-branch.r60] json: add struct tag option to wra... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by adg

Modified:
12 years, 7 months ago

Reviewers:

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

[release-branch.r60] json: add struct tag option to wrap literals in strings ««« CL 4918051 / ba6daf799367 json: add struct tag option to wrap literals in strings Since JavaScript doesn't have [u]int64 types, some JSON APIs encode such types as strings to avoid losing precision. This adds a new struct tag option ",string" to cause fields to be wrapped in JSON strings on encoding and unwrapped from strings when decoding. R=rsc, gustavo CC=golang-dev http://codereview.appspot.com/4918051 »»»

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -32 lines)			Patch
M	src/pkg/json/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/json/decode.go	View	1	7 chunks	+18 lines, -14 lines	0 comments	Download
M	src/pkg/json/decode_test.go	View	1	4 chunks	+5 lines, -0 lines	0 comments	Download
M	src/pkg/json/encode.go	View	1	8 chunks	+41 lines, -18 lines	0 comments	Download
M	src/pkg/json/encode_test.go	View	1	2 chunks	+38 lines, -0 lines	0 comments	Download
A	src/pkg/json/tags.go	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	src/pkg/json/tags_test.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2011-09-19 01:55:30 UTC) #1

adg

12 years, 7 months ago (2011-09-19 01:59:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4f0e6269213f ***

[release-branch.r60] json: add struct tag option to wrap literals in strings

««« CL 4918051 / ba6daf799367
json: add struct tag option to wrap literals in strings

Since JavaScript doesn't have [u]int64 types, some JSON APIs
encode such types as strings to avoid losing precision.

This adds a new struct tag option ",string" to cause
fields to be wrapped in JSON strings on encoding
and unwrapped from strings when decoding.

R=rsc, gustavo
CC=golang-dev
http://codereview.appspot.com/4918051
»»»

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/5049043

Expand All Messages | Collapse All Messages