code review 5029043: [release-branch.r60] json: fix decode bug with struct t...

[release-branch.r60] json: fix decode bug with struct tag names with ,opts being ignored

««« CL 4965049 / f8e4df3c4048
json: fix decode bug with struct tag names with ,opts being ignored

When the encoder was updated to respect the ",omitempty"
struct tag options, the decoder half was never updated to know
about the new struct tag format. (the format is now an optional
name, followed by zero or more ",option" strings)

This only affected people who used ",omitempty" along with
a field name. In that case, the serialized JSON wouldn't
decode to the original value.

R=golang-dev, dvyukov
CC=golang-dev
http://codereview.appspot.com/4965049
»»»

[adg, 2011-09-19 01:42:10]

Hello dsymonds (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-09-19 01:44:30]

LGTM

[adg, 2011-09-19 01:54:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=d5e97874fe84 ***

[release-branch.r60] json: fix decode bug with struct tag names with ,opts being
ignored

««« CL 4965049 / f8e4df3c4048
json: fix decode bug with struct tag names with ,opts being ignored

When the encoder was updated to respect the ",omitempty"
struct tag options, the decoder half was never updated to know
about the new struct tag format. (the format is now an optional
name, followed by zero or more ",option" strings)

This only affected people who used ",omitempty" along with
a field name. In that case, the serialized JSON wouldn't
decode to the original value.

R=golang-dev, dvyukov
CC=golang-dev
http://codereview.appspot.com/4965049
»»»

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/5029043