Issue 50240044: code review 50240044: database/sql: avoiding fmt.Sprintf while scanning, avoi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50240044: code review 50240044: database/sql: avoiding fmt.Sprintf while scanning, avoi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by bradfitz

Modified:
10 years, 3 months ago

Reviewers:
ioe

CC:
golang-codereviews, ioe

Visibility:
Public.

Description

database/sql: avoiding fmt.Sprintf while scanning, avoid allocs with RawBytes A user reported heavy contention on fmt's printer cache. Avoid fmt.Sprint. We have to do reflection anyway, and there was already an asString function to use strconv, so use it. This CL also eliminates a redundant allocation + copy when scanning into *[]byte (avoiding the intermediate string) and avoids an extra alloc when assigning to a caller's RawBytes (trying to reuse the caller's memory). Fixes Issue 7086

Patch Set 1 #

Patch Set 2 : diff -r e4b3e3c1edda https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e4b3e3c1edda https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b4280f484ccf https://go.googlecode.com/hg/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -13 lines)			Patch
	M	src/pkg/database/sql/convert.go	View	1 2	2 chunks	+37 lines, -13 lines	0 comments	Download
	M	src/pkg/database/sql/convert_test.go	View	1 2	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 3 months ago (2014-01-10 00:03:59 UTC) #1

bradfitz

10 years, 3 months ago (2014-01-10 20:19:39 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=60dd219ea8e3 ***

database/sql: avoiding fmt.Sprintf while scanning, avoid allocs with RawBytes

A user reported heavy contention on fmt's printer cache. Avoid
fmt.Sprint. We have to do reflection anyway, and there was
already an asString function to use strconv, so use it.

This CL also eliminates a redundant allocation + copy when
scanning into *[]byte (avoiding the intermediate string)
and avoids an extra alloc when assigning to a caller's RawBytes
(trying to reuse the caller's memory).

Fixes Issue 7086

R=golang-codereviews, nightlyone
CC=golang-codereviews
https://codereview.appspot.com/50240044

Expand All Messages | Collapse All Messages