code review 5016043: net: reuse channels during io

net: reuse channels during io

[brainman, 2011-09-14 05:55:08]

Hello golang-dev@googlegroups.com (cc: hectorchu@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bsiegert, 2011-09-14 09:12:48]

http://codereview.appspot.com/5016043/diff/3001/src/pkg/net/fd_windows.go
File src/pkg/net/fd_windows.go (right):

http://codereview.appspot.com/5016043/diff/3001/src/pkg/net/fd_windows.go#new...
src/pkg/net/fd_windows.go:63: if mode == 'r' {
I don't like the handling of the mode bit here. You could do one of two things:

1. use an enumeration, something like:

const mRead = 0
const mWrite = 1

2. Replace the two-element array below by two members, for the read and write
case respectively.

[rsc, 2011-09-14 15:01:24]

On Wed, Sep 14, 2011 at 05:12,  <bsiegert@gmail.com> wrote:
> I don't like the handling of the mode bit here.

It is consistent with the rest of the package, and
just as efficient as using 0 and 1.

Russ

[bsiegert, 2011-09-15 11:27:55]

On Wed, Sep 14, 2011 at 17:01, Russ Cox <rsc@golang.org> wrote:
> On Wed, Sep 14, 2011 at 05:12,  <bsiegert@gmail.com> wrote:
>> I don't like the handling of the mode bit here.
>
> It is consistent with the rest of the package, and
> just as efficient as using 0 and 1.

Ok then.

--Benny.

[hector, 2011-09-15 12:00:28]

Can't see any issues with this, LGTM.  Thankfully the rio and wio locks stop two
reads or writes from happening on the same fd simultaneously.

[rsc, 2011-09-15 15:20:39]

LGTM

[brainman, 2011-09-16 03:40:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=ec084c7a70c9 ***

net: reuse channels during io

R=golang-dev, bsiegert, rsc, hectorchu
CC=golang-dev
http://codereview.appspot.com/5016043