Issue 49940043: code review 49940043: A+C: sqweek (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49940043: code review 49940043: A+C: sqweek (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by iant

Modified:
10 years, 4 months ago

Reviewers:
bradfitz

CC:
gobot_swtch.com, golang-codereviews

Visibility:
Public.

Description

A+C: sqweek (individual CLA) Generated by addca.

Patch Set 1 #

Patch Set 2 : diff -r 884801fb67af https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 884801fb67af https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 99a1e180eda3 https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello gobot@swtch.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 4 months ago (2014-01-09 17:33:33 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=343d56678086 *** A+C: sqweek (individual CLA) Generated by addca. R=gobot CC=golang-codereviews https://codereview.appspot.com/49940043

10 years, 4 months ago (2014-01-09 17:33:37 UTC) #2

bradfitz

If this was done with addca, why isn't it sorted? In any case, fixed by ...

10 years, 4 months ago (2014-01-09 17:43:33 UTC) #3

iant

10 years, 4 months ago (2014-01-09 18:02:02 UTC) #4

On Thu, Jan 9, 2014 at 9:43 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> If this was done with addca, why isn't it sorted?

He signed the CLA twice, once as sqweek and then again as Rowan Worth.
addca picked up the first, and I manually changed it to the second,
and forgot to sort.  In retrospect I should have done a review since I
did a manual change.

> In any case, fixed by https://codereview.appspot.com/49950043

Thanks for fixing it.

Ian


> On Thu, Jan 9, 2014 at 9:33 AM, <iant@golang.org> wrote:
>>
>> *** Submitted as
>> https://code.google.com/p/go/source/detail?r=343d56678086 ***
>>
>>
>> A+C: sqweek (individual CLA)
>>
>> Generated by addca.
>>
>> R=gobot
>> CC=golang-codereviews
>> https://codereview.appspot.com/49940043
>>
>>
>> https://codereview.appspot.com/49940043/
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages