Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(516)

Issue 49920048: code review 49920048: net: plan9 changes for default net directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by jas
Modified:
11 years, 1 month ago
Reviewers:
mischief, rsc
CC:
golang-codereviews, 0intro, rsc
Visibility:
Public.

Description

net: plan9 changes for default net directory This change include updates to the probeIPv4Stack and probeIPv6Stack to ensure that one or both protocols are supported by ip(3). The addition of fdMutex to netFD fixes the TestTCPConcurrentAccept failures. Additional changes add support for keepalive.

Patch Set 1 #

Patch Set 2 : diff -r ca4b7db0560c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6d8511a61827 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2df447356d7f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 2df447356d7f https://code.google.com/p/go/ #

Patch Set 6 : diff -r c249c52cd276 https://code.google.com/p/go/ #

Patch Set 7 : diff -r c249c52cd276 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -51 lines) Patch
M src/pkg/net/fd_plan9.go View 1 2 3 4 5 4 chunks +106 lines, -5 lines 0 comments Download
M src/pkg/net/file_plan9.go View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/net/ipsock_plan9.go View 1 2 3 4 chunks +46 lines, -16 lines 0 comments Download
src/pkg/net/lookup_plan9.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
A src/pkg/net/sockopt_plan9.go View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
src/pkg/net/tcpsock_plan9.go View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
src/pkg/net/tcpsockopt_plan9.go View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M src/pkg/net/udpsock_plan9.go View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
jas
Hello golang-codereviews@googlegroups.com (cc: 0intro@gmail.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-01-20 21:04:14 UTC) #1
0intro
It works for me. Beware to remove the leading spaces in your description.
11 years, 1 month ago (2014-01-20 21:57:43 UTC) #2
rsc
LGTM
11 years, 1 month ago (2014-01-22 21:12:43 UTC) #3
0intro
*** Submitted as https://code.google.com/p/go/source/detail?r=3a22bef698ba *** net: plan9 changes for default net directory This change include ...
11 years, 1 month ago (2014-01-22 21:22:36 UTC) #4
mischief
this code appears to require that 127.0.0.1 be set up. is that intentional? 9front in ...
11 years, 1 month ago (2014-01-26 02:31:48 UTC) #5
jas
We do need something that distinguishes between IPv4 & IPv6. I could go for defaulting ...
11 years, 1 month ago (2014-01-26 06:20:50 UTC) #6
mischief
11 years, 1 month ago (2014-01-26 06:36:26 UTC) #7
Message was sent while issue was closed.
On 2014/01/26 06:20:50, jas wrote:
> We do need something that distinguishes between IPv4 & IPv6.
> I could go for defaulting to always acknowledging IPv4, though from the
sources
> /rc/bin/cpurc we do get:

does a search for for 4i in /net/iproute in probeIPv4Stack() instead of
searching for 127.0.0.1 in /net/ipselftab not distinguish between ipv4 and ipv6?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b