code review 49920048: net: plan9 changes for default net directory

net: plan9 changes for default net directory
     This change include updates to the probeIPv4Stack
     and probeIPv6Stack to ensure that one or both
     protocols are supported by ip(3).
     The addition of fdMutex to netFD fixes the
     TestTCPConcurrentAccept failures.
     Additional changes add support for keepalive.

[jas, 2014-01-20 21:04:14]

Hello golang-codereviews@googlegroups.com (cc: 0intro@gmail.com,
rsc@golang.org),

I'd like you to review this change to
https://code.google.com/p/go/

[0intro, 2014-01-20 21:57:43]

It works for me.

Beware to remove the leading spaces in your description.

[rsc, 2014-01-22 21:12:43]

LGTM

[0intro, 2014-01-22 21:22:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a22bef698ba ***

net: plan9 changes for default net directory

This change include updates to the probeIPv4Stack
and probeIPv6Stack to ensure that one or both
protocols are supported by ip(3).
The addition of fdMutex to netFD fixes the
TestTCPConcurrentAccept failures.
Additional changes add support for keepalive.

R=golang-codereviews, 0intro
CC=golang-codereviews, rsc
https://codereview.appspot.com/49920048

Committer: David du Colombier <0intro@gmail.com>

[mischief, 2014-01-26 02:31:48]

this code appears to require that 127.0.0.1 be set up. is that intentional?

9front in particular does not automatically setup 127.0.0.1.

[jas, 2014-01-26 06:20:50]

We do need something that distinguishes between IPv4 & IPv6.
I could go for defaulting to always acknowledging IPv4, though from the sources
/rc/bin/cpurc we do get:

if(! grep -s 127.0.0.1 /net/ipselftab)
	ip/ipconfig loopback /dev/null 127.1

which would resolve correctly.

And there's always /lib/ndb/local:

#
#  because the public demands the name localsource
#
ip=127.0.0.1 sys=localhost dom=localhost


The probe could get rid of bufSize.

[mischief, 2014-01-26 06:36:26]

On 2014/01/26 06:20:50, jas wrote:
> We do need something that distinguishes between IPv4 & IPv6.
> I could go for defaulting to always acknowledging IPv4, though from the
sources
> /rc/bin/cpurc we do get:

does a search for for 4i in /net/iproute in probeIPv4Stack() instead of
searching for 127.0.0.1 in /net/ipselftab not distinguish between ipv4 and ipv6?