Issue 49910043: code review 49910043: fmt: make benchmarks parallel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49910043: code review 49910043: fmt: make benchmarks parallel (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by dvyukov

Modified:
10 years, 3 months ago

Reviewers:
golang-codereviews, bradfitz

CC:
golang-codereviews

Visibility:
Public.

Description

fmt: make benchmarks parallel This seems to be the best target to benchmark sync.Pool changes.

Patch Set 1 #

Patch Set 2 : diff -r 99a1e180eda3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 99a1e180eda3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : code review 49910043: fmt: make benchmarks parallel #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
		~rietveld~placeholder~	View	2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 3 months ago (2014-01-09 16:11:27 UTC) #1

bradfitz

LGTM I wonder whether we should make the testing package provide some of this parallel ...

10 years, 3 months ago (2014-01-09 21:27:35 UTC) #2

dvyukov

10 years, 3 months ago (2014-01-10 09:43:45 UTC) #3

On 2014/01/09 21:27:35, bradfitz wrote:
> LGTM
> 
> I wonder whether we should make the testing package provide some of this
> parallel benchmark stuff.

Sorry I've accidentally deleted the single file from this CL. And now clpatch
aborts so I cannot submit it...
I've resent it as:
https://codereview.appspot.com/50140045

R=close

Expand All Messages | Collapse All Messages