code review 4983042: godoc index: first step towards reducing index size

godoc index: first step towards reducing index size

- canonicalize package descriptors
- remove duplicate storage of file paths
- reduces (current) written index file by approx 3.5MB
(from 28434237B to 24686643B, or 13%)

- next step: untangle DAG (when serializing, using
gob, the index dag explodes into an index tree)

[gri, 2011-08-31 00:12:51]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-08-31 01:40:14]

LGTM

You could replace
  if pak, found := x.packages[key]; found {
with
  if pak := x.packages[key]; pak != nil {

[gri, 2011-08-31 01:45:56]

simplified to:

	key := path + ":" + name
	pak := x.packages[key]
	if pak == nil {
		pak = &Pak{path, name}
		x.packages[key] = pak
	}
	return pak

- gri

On Tue, Aug 30, 2011 at 6:40 PM, David Symonds <dsymonds@golang.org> wrote:
> LGTM
>
> You could replace
>
>   if pak, found := x.packages[key]; found {
> with
>   if pak := x.packages[key]; pak != nil {
>

[gri, 2011-08-31 01:47:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=d88a2e32898d ***

godoc index: first step towards reducing index size

- canonicalize package descriptors
- remove duplicate storage of file paths
- reduces (current) written index file by approx 3.5MB
(from 28434237B to 24686643B, or 13%)

- next step: untangle DAG (when serializing, using
gob, the index dag explodes into an index tree)

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/4983042