Issue 4977046: code review 4977046: go spec: update section on Implementation Differences

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4977046: code review 4977046: go spec: update section on Implementation Differences (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gri

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

go spec: update section on Implementation Differences

Patch Set 1 #

Patch Set 2 : diff -r b40261e3f02e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fac03652f1fd https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	doc/go_spec.html	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2011-08-31 22:02:45 UTC) #1

gri

? they are fixed, which why I removed this line - gri On Wed, Aug ...

12 years, 8 months ago (2011-08-31 22:08:30 UTC) #3

rsc

actually i take it back. the nil channel and nil map stuff is fixed in ...

12 years, 8 months ago (2011-08-31 22:09:39 UTC) #5

gri

PTAL On Wed, Aug 31, 2011 at 3:09 PM, Russ Cox <rsc@golang.org> wrote: > actually ...

12 years, 8 months ago (2011-08-31 22:12:40 UTC) #6

gri

12 years, 8 months ago (2011-08-31 22:17:03 UTC) #9

*** Submitted as http://code.google.com/p/go/source/detail?r=f845253df880 ***

go spec: update section on Implementation Differences

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4977046

Expand All Messages | Collapse All Messages