Issue 4974065: code review 4974065: undo CL 4964067 / 661cb84cc6f0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4974065: code review 4974065: undo CL 4964067 / 661cb84cc6f0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gri

Modified:
12 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

undo CL 4964067 / 661cb84cc6f0 API change. Needs further reflection. ««« original CL description path/filepath: Simplify Walk interface The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes issue 2237. R=golang-dev, gri, r CC=golang-dev http://codereview.appspot.com/4964067 Committer: Robert Griesemer <gri@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 661cb84cc6f0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 661cb84cc6f0 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -45 lines)			Patch
M	src/cmd/gofix/main.go	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/cmd/gofmt/gofmt.go	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/cmd/govet/govet.go	View	1	1 chunk	+7 lines, -11 lines	0 comments	Download
M	src/pkg/path/filepath/path.go	View	1	3 chunks	+15 lines, -9 lines	0 comments	Download
M	src/pkg/path/filepath/path_test.go	View	1	3 chunks	+16 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2011-09-07 22:18:18 UTC) #1

gri

12 years, 8 months ago (2011-09-07 22:19:58 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=678116cefc3d ***

undo CL 4964067 / 661cb84cc6f0

API change. Needs further reflection.

««« original CL description
path/filepath: Simplify Walk interface

The last argument of filepath.Walk was removed, and the Visitor
interface now contains an Error method that is called on errors.

Fixes issue 2237.

R=golang-dev, gri, r
CC=golang-dev
http://codereview.appspot.com/4964067

Committer: Robert Griesemer <gri@golang.org>
»»»

R=r
CC=golang-dev
http://codereview.appspot.com/4974065

Expand All Messages | Collapse All Messages