Issue 4974061: code review 4974061: Fix filenames embedded in .o files on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4974061: code review 4974061: Fix filenames embedded in .o files on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by hector

Modified:
13 years, 7 months ago

Reviewers:

CC:
brainman, rsc, golang-dev

Visibility:
Public.

Description

Fix filenames embedded in .o files on Windows Verified with objdump -W.

Patch Set 1 #

Patch Set 2 : diff -r b7badceba5ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7badceba5ec https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -48 lines)			Patch
M	include/libc.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5a/lex.c	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/5c/swt.c	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/6c/swt.c	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/8c/swt.c	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hector

Hello alex.brainman@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-09-06 19:49:05 UTC) #1

rsc

13 years, 7 months ago (2011-09-07 19:49:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fcaa0a920142 ***

5a, 5c, 6a, 6c, 8a, 8c: fix Windows file paths

Verified with objdump -W.

R=alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/4974061

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages