code review 49740045: go/parser: slightly improved error message by adding hint

go/parser: slightly improved error message by adding hint

It's difficult to make this much better w/o much
more effort. This is a rare case and probably not
worth it.

Fixes issue 6052.

[gri, 2014-01-09 22:00:22]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-01-09 22:30:21]

Is this the first (did you mean?) in go/parser?



On Thu, Jan 9, 2014 at 2:00 PM, <gri@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/parser: slightly improved error message by adding hint
>
> It's difficult to make this much better w/o much
> more effort. This is a rare case and probably not
> worth it.
>
> Fixes issue 6052.
>
> Please review this at https://codereview.appspot.com/49740045/
>
> Affected files (+1, -1 lines):
>   M src/pkg/go/parser/parser.go
>
>
> Index: src/pkg/go/parser/parser.go
> ===================================================================
> --- a/src/pkg/go/parser/parser.go
> +++ b/src/pkg/go/parser/parser.go
> @@ -1752,7 +1752,7 @@
>         if es, isExpr := s.(*ast.ExprStmt); isExpr {
>                 return p.checkExpr(es.X)
>         }
> -       p.error(s.Pos(), "expected condition, found simple statement")
> +       p.error(s.Pos(), "expected condition, found simple statement
> (missing parentheses around composite literal?)")
>         return &ast.BadExpr{From: s.Pos(), To: s.End()}
>  }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[gri, 2014-01-09 22:38:41]

yes

(a real fix is pretty complicated and not worth it)



On Thu, Jan 9, 2014 at 2:30 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Is this the first (did you mean?) in go/parser?
>
>
>
> On Thu, Jan 9, 2014 at 2:00 PM, <gri@golang.org> wrote:
>
>> Reviewers: golang-codereviews,
>>
>> Message:
>> Hello golang-codereviews@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> go/parser: slightly improved error message by adding hint
>>
>> It's difficult to make this much better w/o much
>> more effort. This is a rare case and probably not
>> worth it.
>>
>> Fixes issue 6052.
>>
>> Please review this at https://codereview.appspot.com/49740045/
>>
>> Affected files (+1, -1 lines):
>>   M src/pkg/go/parser/parser.go
>>
>>
>> Index: src/pkg/go/parser/parser.go
>> ===================================================================
>> --- a/src/pkg/go/parser/parser.go
>> +++ b/src/pkg/go/parser/parser.go
>> @@ -1752,7 +1752,7 @@
>>         if es, isExpr := s.(*ast.ExprStmt); isExpr {
>>                 return p.checkExpr(es.X)
>>         }
>> -       p.error(s.Pos(), "expected condition, found simple statement")
>> +       p.error(s.Pos(), "expected condition, found simple statement
>> (missing parentheses around composite literal?)")
>>         return &ast.BadExpr{From: s.Pos(), To: s.End()}
>>  }
>>
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

[adonovan, 2014-01-09 22:43:59]

On 2014/01/09 22:38:41, gri wrote:
> yes
> 
> (a real fix is pretty complicated and not worth it)
> 
> 
> 
> On Thu, Jan 9, 2014 at 2:30 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
> 
> > Is this the first (did you mean?) in go/parser?
> >
> >
> >
> > On Thu, Jan 9, 2014 at 2:00 PM, <mailto:gri@golang.org> wrote:
> >
> >> Reviewers: golang-codereviews,
> >>
> >> Message:
> >> Hello mailto:golang-codereviews@googlegroups.com,
> >>
> >> I'd like you to review this change to
> >> https://code.google.com/p/go/
> >>
> >>
> >> Description:
> >> go/parser: slightly improved error message by adding hint
> >>
> >> It's difficult to make this much better w/o much
> >> more effort. This is a rare case and probably not
> >> worth it.
> >>
> >> Fixes issue 6052.
> >>
> >> Please review this at https://codereview.appspot.com/49740045/
> >>
> >> Affected files (+1, -1 lines):
> >>   M src/pkg/go/parser/parser.go
> >>
> >>
> >> Index: src/pkg/go/parser/parser.go
> >> ===================================================================
> >> --- a/src/pkg/go/parser/parser.go
> >> +++ b/src/pkg/go/parser/parser.go
> >> @@ -1752,7 +1752,7 @@
> >>         if es, isExpr := s.(*ast.ExprStmt); isExpr {
> >>                 return p.checkExpr(es.X)
> >>         }
> >> -       p.error(s.Pos(), "expected condition, found simple statement")
> >> +       p.error(s.Pos(), "expected condition, found simple statement
> >> (missing parentheses around composite literal?)")
> >>         return &ast.BadExpr{From: s.Pos(), To: s.End()}
> >>  }
> >>
> >>
> >>
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "golang-codereviews" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an
> >> email to mailto:golang-codereviews+unsubscribe@googlegroups.com.
> >> For more options, visit https://groups.google.com/groups/opt_out.
> >>
> >
> >

LGTM

A 1-line comment showing the hinted-at syntax would help.

[gri, 2014-01-09 22:51:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=97922776ba6f ***

go/parser: slightly improved error message by adding hint

It's difficult to make this much better w/o much
more effort. This is a rare case and probably not
worth it.

Fixes issue 6052.

R=golang-codereviews, bradfitz, adonovan
CC=golang-codereviews
https://codereview.appspot.com/49740045