Issue 4973043: code review 4973043: runtime: openbsd thread tweaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4973043: code review 4973043: runtime: openbsd thread tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by jsing

Modified:
13 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: openbsd thread tweaks - Rename sys_sched_yield() to osyield() as this is now defined in asm.h. - Only print kern.rtheads message if rfork_thread() failed with ENOTSUP. - Remove unused variables.

Patch Set 1 : diff -r 5e1053337103 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	src/pkg/runtime/openbsd/amd64/sys.s	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/pkg/runtime/openbsd/thread.c	View		3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-27 14:08:00 UTC) #1

rsc

13 years, 8 months ago (2011-08-29 13:35:16 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=18c733109246 ***

runtime: openbsd thread tweaks

- Rename sys_sched_yield() to osyield() as this is now defined in asm.h.
- Only print kern.rtheads message if rfork_thread() failed with ENOTSUP.
- Remove unused variables.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4973043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages