code review 4968070: weekly.2011-09-07

weekly.2011-09-07

[adg, 2011-09-07 04:04:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-09-07 04:04:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-09-07 04:09:51]

LGTM

http://codereview.appspot.com/4968070/diff/3001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/4968070/diff/3001/doc/devel/weekly.html#newcode29
doc/devel/weekly.html:29: * fmt: count mallocs in a few more test cases.
is this worth mentioning?

[adg, 2011-09-07 04:14:27]

I'm going to hold off submitting this until either
http://codereview.appspot.com/4972056/ is submitted or Russ says he
doesn't want to include it in this weekly. Either way, tomorrow.

On 7 September 2011 14:09,  <dsymonds@golang.org> wrote:
>
http://codereview.appspot.com/4968070/diff/3001/doc/devel/weekly.html#newcode29
> doc/devel/weekly.html:29: * fmt: count mallocs in a few more test cases.
> is this worth mentioning?

Probably not. Dropped.

[rsc, 2011-09-07 18:25:00]

looks good but lots has happened today...

http://codereview.appspot.com/4968070/diff/3001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/4968070/diff/3001/doc/devel/weekly.html#newcode32
doc/devel/weekly.html:32: unify stack frame layout,
d

[adg, 2011-09-07 22:52:52]

Hello dsymonds@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-09-07 22:56:12]

LGTM

[adg, 2011-09-07 23:43:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=c77997547d54 ***

weekly.2011-09-07

R=dsymonds, rsc, r
CC=golang-dev
http://codereview.appspot.com/4968070