Issue 4963054: code review 4963054: template: fix deadlock.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4963054: code review 4963054: template: fix deadlock. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by r

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

template: fix deadlock. No need for lexInsideAction to loop. Fixes issue 2217.

Patch Set 1 #

Patch Set 2 : diff -r f6449df27a7f https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -43 lines)			Patch
	M	src/pkg/template/parse/lex.go	View		1 chunk	+41 lines, -43 lines	0 comments	Download
	M	src/pkg/template/parse/lex_test.go	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2011-09-02 00:56:12 UTC) #1

:) On Fri, Sep 2, 2011 at 10:59 AM, <bradfitz@golang.org> wrote: > LGTM > > ...

12 years, 8 months ago (2011-09-02 01:00:31 UTC) #3

12 years, 8 months ago (2011-09-02 01:00:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c581abafc917 ***

template: fix deadlock.
No need for lexInsideAction to loop.
Fixes issue 2217.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4963054

Expand All Messages | Collapse All Messages