code review 4962041: http: return 413 instead of 400 when the request body i...

http: return 413 instead of 400 when the request body is too large

RFC2616 says servers should return this status code when
rejecting requests that are too large.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.14

[dave_cheney.net, 2011-08-25 09:10:58]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-08-25 09:15:17]

LGTM

On Thu, Aug 25, 2011 at 1:10 PM, <dave@cheney.net> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> http: return 413 when request body is too large
>
> RFC2616 says servers should return this status code when
> rejecting requests that are too large.
>
>
http://www.w3.org/Protocols/**rfc2616/rfc2616-sec10.html#**sec10.4.14<http://...
>
> Please review this at
http://codereview.appspot.com/**4962041/<http://codereview.appspot.com/4962041/>
>
> Affected files:
>  M src/pkg/http/serve_test.go
>  M src/pkg/http/server.go
>
>
> Index: src/pkg/http/serve_test.go
> ==============================**==============================**=======
> --- a/src/pkg/http/serve_test.go
> +++ b/src/pkg/http/serve_test.go
> @@ -891,8 +891,8 @@
>                // we do support it (at least currently), so we expect a
> response below.
>                t.Fatalf("Do: %v", err)
>        }
> -       if res.StatusCode != 400 {
> -               t.Fatalf("expected 400 response status; got: %d %s",
> res.StatusCode, res.Status)
> +       if res.StatusCode != 413 {
> +               t.Fatalf("expected 413 response status; got: %d %s",
> res.StatusCode, res.Status)
>        }
>  }
>
> Index: src/pkg/http/server.go
> ==============================**==============================**=======
> --- a/src/pkg/http/server.go
> +++ b/src/pkg/http/server.go
> @@ -572,7 +572,7 @@
>                                // responding to them and hanging up
>                                // while they're still writing their
>                                // request.  Undefined behavior.
> -                               msg = "400 Request Too Large"
> +                               msg = "413 Request Entity Too Large"
>                        } else if neterr, ok := err.(net.Error); ok &&
> neterr.Timeout() {
>                                break // Don't reply
>                        }
>
>
>

[dave_cheney.net, 2011-08-25 09:39:08]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2011-08-25 10:00:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=0b0c8a77092a ***

http: return 413 instead of 400 when the request body is too large

RFC2616 says servers should return this status code when
rejecting requests that are too large.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.14

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4962041

Committer: Brad Fitzpatrick <bradfitz@golang.org>