Issue 4937045: code review 4937045: effective go: extract and test a couple more examples.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4937045: code review 4937045: effective go: extract and test a couple more examples. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by r

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

effective go: extract and test a couple more examples.

Patch Set 1 #

Patch Set 2 : diff -r 650da744cd42 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -84 lines)			Patch
M	doc/effective_go.html	View	4 chunks	+21 lines, -20 lines	0 comments	Download
M	doc/effective_go.tmpl	View	2 chunks	+3 lines, -64 lines	0 comments	Download
A	doc/progs/eff_bytesize.go	View	1 chunk	+47 lines, -0 lines	0 comments	Download
A	doc/progs/eff_sequence.go	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	doc/progs/run	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-08-22 11:59:19 UTC) #1

bradfitz

LGTM On Mon, Aug 22, 2011 at 3:59 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years, 7 months ago (2011-08-22 12:44:26 UTC) #2

13 years, 7 months ago (2011-08-22 12:47:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6747998c1959 ***

effective go: extract and test a couple more examples.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4937045

Expand All Messages | Collapse All Messages