Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 4923043: code review 4923043: effective_go: convert to use tmpltohtml. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by r
Modified:
13 years, 7 months ago
Reviewers:
jacek.masiulaniec, dsymonds, r2
CC:
golang-dev, adg
Visibility:
Public.

Description

effective_go: convert to use tmpltohtml. Also update the big example to the new template system. There are a number of other examples that should be extracted; this CL serves as an introduction to the approach.

Patch Set 1 #

Patch Set 2 : diff -r 34cedb43d4ce https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3069 lines, -48 lines) Patch
M doc/Makefile View 1 chunk +7 lines, -0 lines 0 comments Download
M doc/effective_go.html View 5 chunks +33 lines, -47 lines 1 comment Download
A doc/effective_go.tmpl View 1 chunk +2980 lines, -0 lines 0 comments Download
M doc/makehtml View 1 chunk +1 line, -1 line 0 comments Download
A doc/progs/eff_qr.go View 1 chunk +47 lines, -0 lines 0 comments Download
M doc/progs/run View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-20 23:03:55 UTC) #1
adg
LGTM
13 years, 7 months ago (2011-08-20 23:43:48 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=c85e630263ae *** effective_go: convert to use tmpltohtml. Also update the big example ...
13 years, 7 months ago (2011-08-20 23:46:30 UTC) #3
jacekm
http://codereview.appspot.com/4923043/diff/4001/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4923043/diff/4001/doc/effective_go.html#newcode2996 doc/effective_go.html:2996: The piece from the <code></code> executes only if the ...
13 years, 7 months ago (2011-08-21 07:07:31 UTC) #4
r2
On 21/08/2011, at 5:07 PM, Jacek.Masiulaniec@gmail.com wrote: > > http://codereview.appspot.com/4923043/diff/4001/doc/effective_go.html > File doc/effective_go.html (right): > ...
13 years, 7 months ago (2011-08-21 07:44:44 UTC) #5
dsymonds
13 years, 7 months ago (2011-08-21 08:08:28 UTC) #6
The first half says "<code></code>" though. That seems like an error.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b