Issue 4899046: code review 4899046: go/parser: use correct precedence when parsing range clauses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4899046: code review 4899046: go/parser: use correct precedence when parsing range clauses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by gri

Modified:
12 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/parser: use correct precedence when parsing range clauses Fixes issue 2156.

Patch Set 1 #

Patch Set 2 : diff -r c94708477811 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c94708477811 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c94708477811 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c94708477811 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r c57a199556d7 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	src/pkg/go/parser/parser.go	View	1 2 3 4 5	5 chunks	+11 lines, -14 lines	0 comments	Download
	M	src/pkg/go/parser/parser_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-08-16 22:16:40 UTC) #1

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 9 months ago (2011-08-16 22:17:14 UTC) #2

gri

12 years, 9 months ago (2011-08-16 22:19:25 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d6fcfcd397bf ***

go/parser: use correct precedence when parsing range clauses

Fixes issue 2156.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4899046

Expand All Messages | Collapse All Messages