Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2394)

Issue 4889053: code review 4889053: test/chan/select5.go: change "with" to "if" in templatea (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by r
Modified:
12 years, 8 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

test/chan/select5.go: change "with" to "if" in templatea I converted this program yesterday and the output is the same as it used to be, ignoring space, but the result is not the best expression of the algorithm. The old {.section Maybe} pieces are now {{with .Maybe}}, as a direct translation, but I they should be {{if .Maybe}} as the output is just a bool and there is no cascading. I have verified that the output of the program is unaffected.

Patch Set 1 #

Patch Set 2 : diff -r 1ce42d48298d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M test/chan/select5.go View 10 chunks +46 lines, -46 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2011-08-18 02:56:48 UTC) #1
dsymonds
LGTM
12 years, 8 months ago (2011-08-18 02:57:21 UTC) #2
r
12 years, 8 months ago (2011-08-18 03:27:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=8931a1975076 ***

test/chan/select5.go: change "with" to "if" in templatea

I converted this program yesterday and the output is the
same as it used to be, ignoring space, but the result is
not the best expression of the algorithm.  The old {.section
Maybe} pieces are now {{with .Maybe}}, as a direct translation,
but I they should be {{if .Maybe}} as the output is just a
bool and there is no cascading.

I have verified that the output of the program is unaffected.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4889053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b