code review 4867054: mime: ParseMediaType returns os.Error now, not a nil map

mime: ParseMediaType returns os.Error now, not a nil map

ParseMediaType previously documented that it always returned
a non-nil map, but also documented that it returned a nil map
to signal an error.

That is confusing, contradictory and not Go-like.

Now it returns (mediatype string, params map, os.Error).

[bradfitz, 2011-08-15 18:55:47]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-08-15 21:16:42]

can you please hold this off until my url change lands, i hope later today?

-rob

[r, 2011-08-15 21:17:08]

never mind, i see it won't collide.

-rob

[bradfitz, 2011-08-15 21:37:17]

I'm in no rush.  Either way.

On Mon, Aug 15, 2011 at 2:17 PM, Rob 'Commander' Pike <r@golang.org> wrote:

> never mind, i see it won't collide.
>
> -rob
>

[r, 2011-08-15 21:56:41]

LGTM

http://codereview.appspot.com/4867054/diff/5001/src/pkg/mime/mediatype.go
File src/pkg/mime/mediatype.go (right):

http://codereview.appspot.com/4867054/diff/5001/src/pkg/mime/mediatype.go#new...
src/pkg/mime/mediatype.go:41: // The returned params maps from the lowercase
s/returned params/returned map, params,/

[bradfitz, 2011-08-18 19:51:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=5e1502ab5e21 ***

mime: ParseMediaType returns os.Error now, not a nil map

ParseMediaType previously documented that it always returned
a non-nil map, but also documented that it returned a nil map
to signal an error.

That is confusing, contradictory and not Go-like.

Now it returns (mediatype string, params map, os.Error).

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4867054