Issue 4860041: code review 4860041: json: fix []unmarshaler case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4860041: code review 4860041: json: fix []unmarshaler case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by rsc

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Description

json: fix []unmarshaler case Now that reflect has v.Addr(), we can use it.

Patch Set 2 : diff -r d499fb951a9e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d499fb951a9e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 7bf4ad4f42b3 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	src/pkg/json/decode.go	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/pkg/json/decode_test.go	View	1	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2011-08-09 23:17:35 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4860041/diff/4001/src/pkg/json/decode.go File src/pkg/json/decode.go (right): http://codereview.appspot.com/4860041/diff/4001/src/pkg/json/decode.go#newcode254 src/pkg/json/decode.go:254: // If v is a named pointer type ...

12 years, 8 months ago (2011-08-10 00:31:47 UTC) #2

rsc

12 years, 8 months ago (2011-08-10 13:26:56 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9009fa15f80e ***

json: fix []unmarshaler case

Now that reflect has v.Addr(), we can use it.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/4860041

Expand All Messages | Collapse All Messages