Issue 4844055: code review 4844055: html: parse malformed tags missing a '>', such as `<p i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4844055: code review 4844055: html: parse malformed tags missing a '>', such as `<p i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by nigeltao

Modified:
12 years, 8 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

html: parse malformed tags missing a '>', such as `<p id=0</p>`. The additional token_test.go cases matches html5lib behavior. Fixes issue 2124.

Patch Set 1 #

Patch Set 2 : diff -r 40194af9cb12 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 40194af9cb12 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 67206d038559 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -23 lines)			Patch
	M	src/pkg/html/token.go	View	1	5 chunks	+36 lines, -22 lines	0 comments	Download
	M	src/pkg/html/token_test.go	View	1	2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-08-09 06:14:16 UTC) #1

nigeltao

12 years, 8 months ago (2011-08-10 03:39:19 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=914a659b44ff ***

html: parse malformed tags missing a '>', such as `<p id=0</p>`.

The additional token_test.go cases matches html5lib behavior.

Fixes issue 2124.

R=gri
CC=golang-dev
http://codereview.appspot.com/4844055

Expand All Messages | Collapse All Messages