Issue 484041: code review 484041: go/printer: fix a couple of hidden crashes that become

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 484041: code review 484041: go/printer: fix a couple of hidden crashes that become (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer: fix a couple of hidden crashes that become visible only when enabling internal debug mode: - in rare cases expression depth can underflow - when printing a single labeled statement, indentation may underflow if not setup correctly

Patch Set 1 #

Patch Set 2 : code review 484041: go/printer: fix a couple of hidden crashes that become #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	src/pkg/go/printer/nodes.go	View	4 chunks	+12 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.golden	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.input	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-12 21:55:45 UTC) #1

gri

15 years ago (2010-03-12 22:01:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b9de33e89abc ***

go/printer: fix a couple of hidden crashes that become
visible only when enabling internal debug mode:
- in rare cases expression depth can underflow
- when printing a single labeled statement, indentation
  may underflow if not setup correctly

R=rsc
CC=golang-dev
http://codereview.appspot.com/484041

Expand All Messages | Collapse All Messages