Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(339)

Issue 4839056: code review 4839056: exp/template: remove reflect from the API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by r
Modified:
13 years, 7 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

exp/template: remove reflect from the API It means keeping two sets of maps, but things look cleaner from the outside.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 14872cc7275f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -50 lines) Patch
M src/pkg/exp/template/funcs.go View 3 chunks +35 lines, -18 lines 0 comments Download
M src/pkg/exp/template/parse.go View 4 chunks +15 lines, -9 lines 0 comments Download
M src/pkg/exp/template/parse/parse.go View 1 7 chunks +10 lines, -11 lines 0 comments Download
M src/pkg/exp/template/parse/parse_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/exp/template/parse/set.go View 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/exp/template/set.go View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-09 06:20:27 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/4839056/diff/1/src/pkg/exp/template/parse/parse.go File src/pkg/exp/template/parse/parse.go (right): http://codereview.appspot.com/4839056/diff/1/src/pkg/exp/template/parse/parse.go#newcode408 src/pkg/exp/template/parse/parse.go:408: func (t *Tree) findFunction(name string) bool { maybe ...
13 years, 7 months ago (2011-08-09 06:43:59 UTC) #2
r
13 years, 7 months ago (2011-08-09 06:49:46 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3041fde93860 ***

exp/template: remove reflect from the API
It means keeping two sets of maps, but things look cleaner from
the outside.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4839056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b