Issue 4830043: code review 4830043: xml: Header: fix close tag and remove newline

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4830043: code review 4830043: xml: Header: fix close tag and remove newline

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by kevlar

Modified:
12 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

xml: Header: fix close tag and newline

Patch Set 1 #

Patch Set 2 : diff -r 081f44903c4d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 081f44903c4d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 081f44903c4d https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/xml/marshal.go	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kevlar

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-07-29 15:25:34 UTC) #1

kevlar

PTAL On 2011/07/29 16:11:04, rsc wrote: > Thanks, but please keep the newline (use +). ...

12 years, 9 months ago (2011-07-29 18:04:19 UTC) #3

rsc

12 years, 9 months ago (2011-07-29 18:09:13 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=05db05feb3bc ***

xml: Header: fix close tag and newline

R=rsc
CC=golang-dev
http://codereview.appspot.com/4830043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages