Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 48150043: code review 48150043: archive/zip: fix bug reading zip64 files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by bradfitz
Modified:
10 years, 2 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

archive/zip: fix bug reading zip64 files ZIP64 Extra records are variably sized, but we weren't capping our reading of the extra fields at its previously-declared size. No test because I don't know how to easily create such files and don't feel like manually construction one. But all existing tests pass, and this is "obviously correct" (queue laughter). Fixes Issue 7069

Patch Set 1 #

Patch Set 2 : diff -r 8103124b1f63 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8103124b1f63 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2f97de47dca3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/archive/zip/reader.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 2 months ago (2014-01-06 18:22:31 UTC) #1
iant
LGTM Is this worth putting into Go 1.2.1 (if we make one)?
10 years, 2 months ago (2014-01-06 18:37:35 UTC) #2
bradfitz
Yeah, probably. Ideally once we have a test (maybe Andrew knows how to do that ...
10 years, 2 months ago (2014-01-06 18:42:44 UTC) #3
bradfitz
10 years, 2 months ago (2014-01-06 18:43:58 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=fe0a21b4dd1d ***

archive/zip: fix bug reading zip64 files

ZIP64 Extra records are variably sized, but we weren't capping
our reading of the extra fields at its previously-declared
size.

No test because I don't know how to easily create such files
and don't feel like manually construction one.  But all
existing tests pass, and this is "obviously correct" (queue
laughter).

Fixes Issue 7069

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/48150043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b