code review 4812048: archive/zip: handle zip files with more than 65535 files

archive/zip: handle zip files with more than 65535 files

[adg, 2011-07-22 04:48:11]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-22 04:50:01]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-22 04:52:35]

LGTM

[adg, 2011-07-22 04:57:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=f04f95825b5a ***

archive/zip: handle zip files with more than 65535 files

R=r
CC=golang-dev
http://codereview.appspot.com/4812048

[serbaut, 2012-08-09 21:05:32]

I'm adding ZIP64 support to archive/zip and this looks very fishy to me.

For 32 bit zip files there is a limit of 65k files in the spec. I believe 
some tool mistakenly created archives with more files in it and wrapped the 
count at 65k. Java and windows xp are primary suspects:  
https://issues.apache.org/bugzilla/show_bug.cgi?id=53503   
http://help.lockergnome.com/windows/65536-item-limit-bug-Compressed-zipped-Fo...
 

It is probably good to be able read these files but we should not create 
more broken zip files (as the writer does now).

On Friday, July 22, 2011 6:57:22 AM UTC+2, Andrew Gerrand wrote:
>
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=f04f95825b5a ***
>
> archive/zip: handle zip files with more than 65535 files
>
> R=r
> CC=golang-dev
> http://codereview.appspot.com/4812048
>
>
> http://codereview.appspot.com/4812048/
>
>

[adg, 2012-08-10 04:02:00]

You're suggesting we fail when trying to create files with greater than 64k
files?
On 10 Aug 2012 07:05, "Joakim Sernbrant" <serbaut@gmail.com> wrote:

> I'm adding ZIP64 support to archive/zip and this looks very fishy to me.
>
> For 32 bit zip files there is a limit of 65k files in the spec. I believe
> some tool mistakenly created archives with more files in it and wrapped the
> count at 65k. Java and windows xp are primary suspects:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=53503
>
http://help.lockergnome.com/windows/65536-item-limit-bug-Compressed-zipped-Fo...
>
>
> It is probably good to be able read these files but we should not create
> more broken zip files (as the writer does now).
>
> On Friday, July 22, 2011 6:57:22 AM UTC+2, Andrew Gerrand wrote:
>>
>> *** Submitted as
>>
http://code.google.com/p/go/**source/detail?r=f04f95825b5a<http://code.google...
>>
>> archive/zip: handle zip files with more than 65535 files
>>
>> R=r
>> CC=golang-dev
>>
http://codereview.appspot.com/**4812048<http://codereview.appspot.com/4812048>
>>
>>
>>
http://codereview.appspot.com/**4812048/<http://codereview.appspot.com/4812048/>
>>
>>

[serbaut, 2012-08-10 09:00:14]

On 2012/08/10 04:02:00, adg wrote:
> You're suggesting we fail when trying to create files with greater than 64k
> files?

That would be the sane thing to do. However I looked at the source for zip 2.32
and it happily creates broken files. zip 3.0 complains about them though:

zip warning: expected 4464 entries but found 70000
zip error: Zip file structure invalid (test.zip)

They can be fixed with zip --fixfix test.zip --out fixed.zip.

I will try to make sure both can be read but that zip64 files will be written
when needed. Must read up on how to submit a patch for review first :)