Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152)

Issue 4810059: code review 4810059: runtime: Fix race introduced by recent scheduler improv... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by hector
Modified:
12 years, 8 months ago
Reviewers:
brainman
CC:
rsc, dvyukov, golang-dev
Visibility:
Public.

Description

runtime: Fix race introduced by recent scheduler improvements. Fixes issue 2100.

Patch Set 1 #

Patch Set 2 : diff -r 05db05feb3bc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 05db05feb3bc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 12
hector
Hello rsc@golang.org, dvyukov@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2011-07-29 20:07:05 UTC) #1
rsc
LGTM Ouch, thanks for tracking this down. This is definitely a bug. I can't quite ...
12 years, 8 months ago (2011-07-29 21:33:15 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=459ea802c68b *** runtime: fix scheduling race Affects programs using cgo or runtime.LockOSThread. ...
12 years, 8 months ago (2011-07-29 21:39:12 UTC) #3
hector
Should've checked it using Promela ;-) /* omitted: lockedm, idlem concerns */ Here's a demo ...
12 years, 8 months ago (2011-07-29 21:44:30 UTC) #4
rsc
It seems like this can happen even without the recent changes. * thread enters syscall ...
12 years, 8 months ago (2011-07-29 21:55:36 UTC) #5
hector
Does this sequence account for the gc thread finishing up? mcpumax isn't restored until gc ...
12 years, 8 months ago (2011-07-29 22:26:23 UTC) #6
rsc
On Fri, Jul 29, 2011 at 18:26, <hectorchu@gmail.com> wrote: > Does this sequence account for ...
12 years, 8 months ago (2011-07-29 22:43:53 UTC) #7
hector
On 2011/07/29 22:43:53, rsc wrote: > On Fri, Jul 29, 2011 at 18:26, <mailto:hectorchu@gmail.com> wrote: ...
12 years, 8 months ago (2011-07-29 22:51:14 UTC) #8
rsc
Ah, yes. I see now. My scenario is impossible. And yours depends on the new ...
12 years, 8 months ago (2011-07-29 22:58:58 UTC) #9
brainman
Thank you for fixing this. I had no idea what to do. Still don't <g>. ...
12 years, 8 months ago (2011-07-31 09:11:16 UTC) #10
hector
No problem at all Alex. Actually to be honest I was suffering from this problem ...
12 years, 8 months ago (2011-07-31 09:17:06 UTC) #11
brainman
12 years, 8 months ago (2011-07-31 09:19:35 UTC) #12
On 2011/07/31 09:17:06, hector wrote:
> I was able to solve this by using the trusty printf (or DbgPrint in
> Windows-land) in strategic locations inside the scheduler.

I know the trick, but you also need to know where to put them :-).

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b