Issue 4809086: code review 4809086: exp/template: do not take address of interface variable...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4809086: code review 4809086: exp/template: do not take address of interface variable... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by r

Modified:
13 years, 7 months ago

Reviewers:
gri

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

exp/template: do not take address of interface variable to find methods. Also allow struct values as "with" targets.

Patch Set 1 #

Patch Set 2 : diff -r 3041fde93860 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3041fde93860 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
	M	src/pkg/exp/template/exec.go	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
	M	src/pkg/exp/template/exec_test.go	View	1	3 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-08-09 06:44:03 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 7 months ago (2011-08-09 07:01:53 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=1edd4df99360 *** exp/template: do not take address of interface variable to find ...

13 years, 7 months ago (2011-08-09 07:07:35 UTC) #4

gri

13 years, 7 months ago (2011-08-09 17:17:05 UTC) #5

Thanks! This fixed the other outstanding issue I had in godoc with the
new template package.
- Robert

On Tue, Aug 9, 2011 at 12:07 AM,  <r@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=1edd4df99360 ***
>
> exp/template: do not take address of interface variable to find methods.
> Also allow struct values as "with" targets.
>
> R=golang-dev, dsymonds
> CC=golang-dev
> http://codereview.appspot.com/4809086
>
>
> http://codereview.appspot.com/4809086/
>

Expand All Messages | Collapse All Messages