Issue 4808062: code review 4808062: net: joined group addresses for a specific interface fo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808062: code review 4808062: net: joined group addresses for a specific interface fo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by mikio

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: joined group addresses for a specific interface for darwin, freebsd, linux This CL enables to list the multicast, joined group addresses for a specific interface by using Interface.MulticastAddrs method.

Patch Set 1 : diff -r 5e1786622fa6 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+260 lines, -14 lines)			Patch
M	src/pkg/net/Makefile	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface_bsd.go	View	1 chunk	+37 lines, -7 lines	0 comments	Download
A	src/pkg/net/interface_darwin.go	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	src/pkg/net/interface_freebsd.go	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface_linux.go	View	3 chunks	+93 lines, -7 lines	0 comments	Download
M	src/pkg/net/interface_stub.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface_test.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface_windows.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-31 17:22:51 UTC) #1

mikio

P.S. This CL requires CL 4826056 to run on BSD variants. On 2011/07/31 17:22:51, mikioh ...

13 years, 7 months ago (2011-07-31 17:25:59 UTC) #2

rsc

13 years, 7 months ago (2011-08-04 04:22:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=6d5c806065c8 ***

net: joined group addresses for a specific interface for darwin, freebsd, linux

This CL enables to list the multicast, joined group addresses
for a specific interface by using Interface.MulticastAddrs
method.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4808062

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages