Issue 4808044: code review 4808044: http: set nil to req.URL when CONNECT method.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808044: code review 4808044: http: set nil to req.URL when CONNECT method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by mattn

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev_googlecode.com, bradfitz, rsc, golang-dev

Visibility:
Public.

Description

http: set nil to req.URL when CONNECT method. CONNECT method require proxy.example.com:8080 like argument. ReadRequest() is treating proxy.example.com as scheme, 8080 as host. so req.URL is broken. This change make req.URL 'nil'.

Patch Set 1 #

Patch Set 2 : diff -r a4c2e46af9b2 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a4c2e46af9b2 http://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	src/pkg/http/readrequest_test.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
	M	src/pkg/http/request.go	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlecode.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-21 07:51:35 UTC) #1

rsc

13 years, 8 months ago (2011-07-21 15:34:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1bd754e69ce7 ***

http: do not parse req.URL for CONNECT

CONNECT's argument is not a URL.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4808044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages