code review 48060043: net/http: remove todos from cookie code

net/http: remove todos from cookie code

The Domain and Path field of a parsed cookie have been
the unprocessed wire data since Go 1.0; this seems to
be okay for most applications so let's keep it.

Returning the unprocessed wire data makes it easy to
handle nonstandard or even broken clients without
consulting Raw or Unparsed of a cookie.

The RFC 6265 parsing rules for domain and path are
currently buried in net/http/cookiejar but could be
exposed in net/http if necessary.

[volker.dobler, 2014-01-06 10:51:54]

Hello bradfitz@golang.org, nigeltao@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-01-06 18:00:51]

LGTM



On Mon, Jan 6, 2014 at 2:51 AM, <dr.volker.dobler@gmail.com> wrote:

> Reviewers: bradfitz, nigeltao,
>
> Message:
> Hello bradfitz@golang.org, nigeltao@golang.org (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/http: remove todos from cookie code
>
> The Domain and Path field of a parsed cookie have been
> the unprocessed wire data since Go 1.0; this seems to
> be okay for most applications so let's keep it.
>
> Returning the unprocessed wire data makes it easy to
> handle nonstandard or even broken clients without
> consulting Raw or Unparsed of a cookie.
>
> The RFC 6265 parsing rules for domain and path are
> currently buried in net/http/cookiejar but could be
> exposed in net/http if necessary.
>
> Please review this at https://codereview.appspot.com/48060043/
>
> Affected files (+0, -2 lines):
>   M src/pkg/net/http/cookie.go
>
>
> Index: src/pkg/net/http/cookie.go
> ===================================================================
> --- a/src/pkg/net/http/cookie.go
> +++ b/src/pkg/net/http/cookie.go
> @@ -94,7 +94,6 @@
>                                 continue
>                         case "domain":
>                                 c.Domain = val
> -                               // TODO: Add domain parsing
>                                 continue
>                         case "max-age":
>                                 secs, err := strconv.Atoi(val)
> @@ -121,7 +120,6 @@
>                                 continue
>                         case "path":
>                                 c.Path = val
> -                               // TODO: Add path parsing
>                                 continue
>                         }
>                         c.Unparsed = append(c.Unparsed, parts[i])
>
>
>

[bradfitz, 2014-01-06 18:01:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=8103124b1f63 ***

net/http: remove todos from cookie code

The Domain and Path field of a parsed cookie have been
the unprocessed wire data since Go 1.0; this seems to
be okay for most applications so let's keep it.

Returning the unprocessed wire data makes it easy to
handle nonstandard or even broken clients without
consulting Raw or Unparsed of a cookie.

The RFC 6265 parsing rules for domain and path are
currently buried in net/http/cookiejar but could be
exposed in net/http if necessary.

R=bradfitz, nigeltao
CC=golang-codereviews
https://codereview.appspot.com/48060043

Committer: Brad Fitzpatrick <bradfitz@golang.org>