Issue 4802043: code review 4802043: tag weekly.2011-07-19

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4802043: code review 4802043: tag weekly.2011-07-19 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by adg

Modified:
13 years, 8 months ago

Reviewers:
r, dsymonds

CC:
golang-dev

Visibility:
Public.

Description

tag weekly.2011-07-19

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	.hgtags	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-20 05:48:33 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=1029b06feb93 *** tag weekly.2011-07-19 R=r CC=golang-dev http://codereview.appspot.com/4802043

13 years, 8 months ago (2011-07-20 05:48:42 UTC) #2

dsymonds

13 years, 8 months ago (2011-07-20 05:57:03 UTC) #4

On Wed, Jul 20, 2011 at 3:54 PM,  <r@golang.org> wrote:

> very nice

I agree. It could have done with a test, though.

Expand All Messages | Collapse All Messages