Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 476043: code review 476043: gofmt: make sure there is a newline after (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by gri
Modified:
15 years ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

gofmt: make sure there is a newline after a /*-style comment at the end of a file Some minor cleanups/typo fixes along the way. Fixes an issue where that newline was removed after applying gofmt.

Patch Set 1 #

Patch Set 2 : code review 476043: gofmt: make sure there is a newline after #

Patch Set 3 : code review 476043: gofmt: make sure there is a newline after #

Patch Set 4 : code review 476043: gofmt: make sure there is a newline after #

Patch Set 5 : code review 476043: gofmt: make sure there is a newline after #

Patch Set 6 : code review 476043: gofmt: make sure there is a newline after #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M src/pkg/go/printer/printer.go View 1 2 3 6 chunks +24 lines, -17 lines 0 comments Download
M src/pkg/go/printer/testdata/comments.golden View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/testdata/comments.input View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/testdata/linebreaks.golden View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/linebreaks.input View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-12 20:00:15 UTC) #1
r2
LGTM On Mar 12, 2010, at 12:00 PM, gri@golang.org wrote: > Reviewers: r, > > ...
15 years ago (2010-03-12 22:46:14 UTC) #2
gri
15 years ago (2010-03-12 22:54:08 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=6392903cd8d0 ***

gofmt: make sure there is a newline after
a /*-style comment at the end of a file

Some minor cleanups/typo fixes along the way.

Fixes an issue where that newline was removed
after applying gofmt.

R=r
CC=golang-dev
http://codereview.appspot.com/476043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b