Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(301)

Issue 47260043: code review 47260043: encoding/json: Fix missing error when trying to unmarsh... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by cehessman
Modified:
10 years, 2 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

encoding/json: Fix missing error when trying to unmarshal null string into int, for successive ,string option Fixes issue 7046.

Patch Set 1 #

Patch Set 2 : diff -r d5dbdcc7f614 https://code.google.com/p/go #

Patch Set 3 : diff -r ba6650c99cdb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/pkg/encoding/json/decode.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3
cehessman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 2 months ago (2014-01-02 22:25:36 UTC) #1
bradfitz
LGTM On Thu, Jan 2, 2014 at 2:25 PM, <c.emil.hessman@gmail.com> wrote: > Reviewers: golang-codereviews, > ...
10 years, 2 months ago (2014-01-03 18:13:01 UTC) #2
bradfitz
10 years, 2 months ago (2014-01-03 18:13:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=efdd955d766c ***

encoding/json: Fix missing error when trying to unmarshal null string into int,
for successive ,string option

Fixes issue 7046.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/47260043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b